Skip to content

fix: make instrumentation optional#6449

Draft
panekj wants to merge 2 commits into
matrix-org:mainfrom
panekj:pj/gate-tracing-instrument
Draft

fix: make instrumentation optional#6449
panekj wants to merge 2 commits into
matrix-org:mainfrom
panekj:pj/gate-tracing-instrument

Conversation

@panekj

@panekj panekj commented Apr 14, 2026

Copy link
Copy Markdown

Fixes #6254

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by:

panekj added 2 commits April 14, 2026 19:04
@panekj
fix: make instrumentation optional
4f1a65a 
Allows to stop instrumenting functions which prevents from
massive log entries due to logged structures.
@panekj
fix: docs
988c820
@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (a9ef675) to head (988c820).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
- Coverage   89.82%   89.46%   -0.37%     
==========================================
  Files         378      378              
  Lines      104337   107974    +3637     
  Branches   104337   107974    +3637     
==========================================
+ Hits        93724    96601    +2877     
- Misses       7015     7456     +441     
- Partials     3598     3917     +319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will degrade performance by 49.52%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 49 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation Restore session [memory store] 112.8 ms 223.4 ms -49.52%

Comparing panekj:pj/gate-tracing-instrument (988c820) with main (dab87b7)

Open in CodSpeed

bnjbvr
bnjbvr reviewed Apr 15, 2026
View reviewed changes

@bnjbvr bnjbvr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like this is on the right track!

Let's make sure to publicize the change by indicating in the CHANGELOG.mds of each of the touched crates that instrumentation is now disabled by default, and can be re-enabled with the Cargo feature.

Also, we'd probably want to enable it on one of the CI tasks, at least, and make sure it's enabled when building the UniFFI bindings: we could either enable the instrument features for the matrix-sdk-ffi crate by default (?), or include it manually for the swift and kotlin bindings generation tasks in the xtask helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bnjbvr bnjbvr bnjbvr left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error: queries overflow the depth limit! with 1.94.0

2 participants

@panekj @bnjbvr